[PATCH 0/3] leds/pwm: don't call pwm_disable when setting brightness

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Fri Feb 21 09:15:07 EST 2014


On Mon, Nov 25, 2013 at 09:43:42PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> some time ago I pointed out a problem with leds-pwm on i.MX28, because
> on this SoC it can happen that after:
> 
> 	pwm_config(pwm, 0, period);
> 	pwm_disable(pwm);
> 
> the connected LED stays on. The mail thread is available at
> 
> 	http://thread.gmane.org/gmane.linux.kernel/1381289
> 
> This series implements the outcome that didn't get any opposition, i.e.
> the pin state is explicitly undefined after pwm_disable. The first patch
> adds this fact to the general pwm docs, the second patch fixes the
> leds-pwm driver accordingly. The third patch is just a trivial fix that
> I noticed while patching the leds-pwm driver and not really related to
> any problem.
> 
> Best regards
> Uwe
Ping. Even if patches 1 and 2 are maybe controversal, patch 3 should be
ok.

Do you still have the problem addressed by the first two patches on your
radar?

Best regards
Uwe
 
> Uwe Kleine-König (3):
>   pwm/doc: Clearify that the pin state after pwm_disable is undefined
>   leds/pwm: Don't disable pwm when setting brightness to 0
>   leds/pwm: fix driver description and make license match the header
> 
>  Documentation/pwm.txt   |  5 +++++
>  drivers/leds/leds-pwm.c | 14 +++++++-------
>  2 files changed, 12 insertions(+), 7 deletions(-)

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list