[RFC PATCH 2/2] arm: mm: Double logical invert for LPAE pte_write(), pte_dirty()

Steve Capper steve.capper at linaro.org
Fri Feb 21 03:39:56 EST 2014


On Thu, Feb 20, 2014 at 05:26:51PM +0000, Will Deacon wrote:
> On Fri, Feb 14, 2014 at 04:55:13PM +0000, Steve Capper wrote:
> > On LPAE, L_PTE_WRITE and L_PTE_DIRTY are in the upper 32-bits.
> > Unfortunately, results from pte_write() and pte_dirty() are downcast
> > to 32-bits by core code:
> >   o gather_stats
> >   o huge_pte_dirty
> >   o huge_pte_write
> >   o make_migration_entry
> > 
> > This patch adds a double logical invert to pte_write() and pte_dirty()
> > for LPAE to ensure that the lower 32-bits are set if true.
> 
> Yikes, this sounds like something we should put in -stable, no? If so,
> better make it patch 1 of this series.

Yeah, it makes sense to have this as the first patch. It probably
should go through stable, I will mark the next version of this patch
for stable.

> 
>   Reviewed-by: Will Deacon <will.deacon at arm.com>

Thanks Will.

Cheers,
--
Steve



More information about the linux-arm-kernel mailing list