[PATCH 1/1] ARM: Exynos: Add generic compatible string

[Sachin Kamat]

Hi Tomasz,

On 19 February 2014 18:15, Tomasz Figa <t.figa at samsung.com> wrote:
> Hi Sachin,
>
> [adding linux-arm-kernel ML to CC list]
>
>
> On 19.02.2014 12:34, Sachin Kamat wrote:
>>
>> To avoid modifying the kernel every time a new SoC variant
>> comes out.
<snip>
>
> Since all Exynos chips can be easily recognized using dedicated chip ID
> register, I wonder whether we really need to maintain two distinct board
> files for Exynos 4 and 5 series, especially when both of them are doing
> mostly the same set up, which can be simply generalized to cover all the
> cases.
>
> Instead of adding just another level of artificially fine grained compatible
> strings, I'd rather suggest merging both board files together and adding a
> single compatible string identifying all SoCs that can be further
> differentiated by using hardware chip ID register.
>
> What do you think?

I agree with your idea of merging both the files as there is very little that is
different for now. However I am not really sure if having a single compatible
string for all SoCs would be good. What is achieved through compatible string
can very well be done using chip ID too. But wouldn't we need to maintain some
unique identity for the SoCs in human readable form at the DT level?
In the absence
of any other opinion, can probably experiment with this and see how it
takes shape.


> P.S. Please always keep respective subsystem/arch level MLs on CC list, in
> this case linux-arm-kernel. The linux-samsung-soc ML is just a convenience
> tool to group all threads about Samsung SoCs, not a way to bypass respective
> subsystem MLs.

Nothing to disagree. A valid point at large, but for every trivial or
exynos specific
change, including top level MLs would probably amount to spamming :)

-- 
With warm regards,
Sachin