Re: [RFC PATCH v2 1/2] mfd: syscon: Support early initialization

[Alexander Shiyan]

Среда, 19 февраля 2014, 15:14 +04:00 от Alexander Shiyan <shc_work at mail.ru>:
> Среда, 19 февраля 2014, 12:04 +01:00 от Michal Simek <michal.simek at xilinx.com>:
> > Some platforms need to get system controller
> > ready as soon as possible.
> > The patch provides early_syscon_initialization
> > which create early mapping for all syscon compatible
> > devices in early_syscon_probe.
> > Regmap is get via syscon_early_regmap_lookup_by_phandle()
> > 
> > Regular device probes attach device to regmap
> > via regmap_attach_dev().
> > 
> > For early syscon initialization is necessary to extend
> > struct syscon and provide remove function
> > which unmap all early init structures.
> > 
> > Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> > ---
> ...
> 
> > +static struct of_device_id of_syscon_ids[] = {
> > +	{ .compatible = "syscon" },
> > +	{},
> >  };
> 
> You should move syscon_ids out of #ifdef CONFIG_OF

Oh, confused, sorry for noise.

---