[PATCH] drivers: net: cpsw: fix buggy loop condition

David Miller davem at davemloft.net
Thu Feb 13 18:51:31 EST 2014


From: Heiko Schocher <hs at denx.de>
Date: Thu, 13 Feb 2014 14:47:27 +0100

> commit:
> From 0cd8f9cc0654c06adde353c6532114c5f53a18e8 Mon Sep 17 00:00:00 2001
> From: Mugunthan V N <mugunthanvnm at ti.com>
> Date: Thu, 23 Jan 2014 00:03:12 +0530
> Subject: [PATCH] drivers: net: cpsw: enable promiscuous mode support

The correct way to reference a commit is:

$(SHA1_ID) ("Commit message header text.")

So in this case it would be:

Commit 0cd8f9cc0654c06adde353c6532114c5f53a18e8 ("drivers: net: cpsw:
enable promiscuous mode support")

I fixed this up when applying this patch.  I will not extend this same
courtesy next time.

> Enable promiscuous mode support for CPSW.
> 
> Introduced a crash on an am335x based board (similiar to am335x-evm).
> Reason is buggy end condition in for loop in cpsw_set_promiscious()
> 
> for (i = 0; i <= priv->data.slaves; i++)
> 
> should be
> 
> for (i = 0; i < priv->data.slaves; i++)
> 
> Fix this ...
> 
> Signed-off-by: Heiko Schocher <hs at denx.de>

Applied, thanks.



More information about the linux-arm-kernel mailing list