[PATCH v2 05/10] ARM: mvebu: add Device Tree for the Armada 375 DB board
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Feb 13 05:56:25 EST 2014
Dear Arnd Bergmann,
On Wed, 12 Feb 2014 14:12:27 +0100, Arnd Bergmann wrote:
> On Wednesday 12 February 2014 11:23:34 Thomas Petazzoni wrote:
> > + i2c0: i2c at 11000 {
> > + status = "okay";
> > + clock-frequency = <100000>;
> > + pinctrl-0 = <&i2c0_pins>;
> > + pinctrl-names = "default";
> > + };
> > +
> > + i2c1: i2c at 11100 {
> > + status = "okay";
> > + clock-frequency = <100000>;
> > + pinctrl-0 = <&i2c1_pins>;
> > + pinctrl-names = "default";
> > + };
>
> I think you should either use the label to reference the node here,
> or omit it in the board.dts file. There is no point in defining
> multiple identical labels.
Indeed, good point. Will be fixed in v3.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list