[PATCH v2 02/10] ARM: mvebu: add initial support for the Armada 375 SOCs

Arnd Bergmann arnd at arndb.de
Wed Feb 12 08:08:42 EST 2014


On Wednesday 12 February 2014 11:23:31 Thomas Petazzoni wrote:
> From: Gregory CLEMENT <gregory.clement at free-electrons.com>
> 
> This commit adds the basic support for the Armada 375 SOCs. These SoCs
> share most of their IP with the Armada 370/XP SoCs. The main
> difference is the use of a Cortex A9 CPU instead of the PJ4B CPU. The
> interrupt controller and the L2 cache controller are also different
> they are respectively the GIC and the PL310.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> ---
>  .../devicetree/bindings/arm/armada-375.txt         |  9 +++++
>  arch/arm/mach-mvebu/Kconfig                        | 15 ++++++++
>  arch/arm/mach-mvebu/Makefile                       |  1 +
>  arch/arm/mach-mvebu/armada-375.c                   | 44 ++++++++++++++++++++++

I don't know what the outcome was for the first version, but just
for the record, I would prefer merging the board file into armada-370-xp.c
without renaming that file. Keeping the separate Kconfig entry makes sense
because we want to select different options there. If you have differences
between the implementations (so far the 370/xp code should just work
on 375), you can use a combination of if(IS_ENABLED(CONFIG_*)) and
if(machine_is_compatible()) to do the detection but keep a common
dt_compat list.

	Arnd



More information about the linux-arm-kernel mailing list