[PATCH] phy-core: Don't allow building phy-core as a module
rogerq at ti.com
Wed Feb 12 03:46:54 EST 2014
On 02/11/2014 06:03 PM, Hans de Goede wrote:
> include/phy/phy.h has stub code in there for when building without the
> phy-core enabled. This is useful for generic drivers such as ahci-platform,
> ehci-platoform and ohci-platform which have support for driving an optional
> phy passed to them through the devicetree.
> Since on some boards this phy functionality is not needed, being able to
> disable the phy subsystem without needing a lot of #ifdef magic in the
> driver using it is quite useful.
> However this breaks when the module using the phy subsystem is build-in and
> the phy-core is not, which leads to the build failing with missing symbol
> errors in the linking stage of the zImage.
> Which leads to gems such as this being added to the Kconfig for achi_platform:
> depends on GENERIC_PHY || !GENERIC_PHY
> Rather then duplicating this code in a lot of places using the phy-core,
> I believe it is better to simply not allow the phy-core to be built as a
> module. The phy core is quite small and has no external dependencies, so
> always building it in when enabling it should not be an issue.
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
Acked-by: Roger Quadros <rogerq at ti.com>
> drivers/phy/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 6070c99..6e336b4 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -5,7 +5,7 @@
> menu "PHY Subsystem"
> config GENERIC_PHY
> - tristate "PHY Core"
> + bool "PHY Core"
> Generic PHY support.
More information about the linux-arm-kernel