[PATCH v2 07/11] watchdog: xilinx: Use of_property_read_u32

Guenter Roeck linux at roeck-us.net
Tue Feb 11 15:20:38 EST 2014


On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote:
> Use of_property_read_u32 functions to clean probe function.
> 
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
> 
[ ... ]

> +
> +	if (enable_once)
>  		watchdog_set_nowayout(xilinx_wdt_wdd, true);
> -	}

	watchdog_set_nowayout(xilinx_wdt_wdd, enable_once);

would probably do as well (the function checks the flag as well).

Nitpick, so

Reviewed-by: Guenter Roeck <linux at roeck-us.net>



More information about the linux-arm-kernel mailing list