[PATCH v2] ARM: asm: rename logical shift macros push pull into lspush lspull
Dave Martin
Dave.Martin at arm.com
Tue Feb 11 10:59:28 EST 2014
On Tue, Feb 11, 2014 at 03:54:37PM +0000, Dave Martin wrote:
> On Mon, Feb 10, 2014 at 04:30:01PM -0500, Nicolas Pitre wrote:
> > On Mon, 10 Feb 2014, Victor Kamensky wrote:
> >
> > > Renames logical shift macros, 'push' and 'pull', defined in
> > > arch/arm/include/asm/assembler.h, into 'lspush' and 'lspull'.
> >
> > I don't have any fundamental objection to the idea, except maybe for the
> > actual names. I just can't come up with anything better though.
>
> For consistency with the get_byte_ stuff, how about:
>
> push -> towards_byte_0
> pull -> from_byte_0
>
> That may make the purpose a little clearer, too.
>
> (Assuming I've got them the right way around...)
(Actually, I did get it the wrong way round by the look of it.
But you get the general idea.)
Cheers
---Dave
More information about the linux-arm-kernel
mailing list