[PATCH] clk:ti: Fix memory leak in of_ti_composite_divider_clk_setup()

Masanari Iida standby24x7 at gmail.com
Tue Feb 11 08:25:41 EST 2014


cppcheck detected following error
[drivers/clk/ti/divider.c:480]: (error) Memory leak: div

The original code forgot to free div and just returned.

Signed-off-by: Masanari Iida <standby24x7 at gmail.com>
---
 drivers/clk/ti/divider.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/ti/divider.c b/drivers/clk/ti/divider.c
index a15e445..a105d94 100644
--- a/drivers/clk/ti/divider.c
+++ b/drivers/clk/ti/divider.c
@@ -477,7 +477,6 @@ static void __init of_ti_composite_divider_clk_setup(struct device_node *node)
 		goto cleanup;
 
 	if (!ti_clk_add_component(node, &div->hw, CLK_COMPONENT_TYPE_DIVIDER))
-		return;
 
 cleanup:
 	kfree(div->table);
-- 
1.9.rc1




More information about the linux-arm-kernel mailing list