[RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder
Dan Carpenter
dan.carpenter at oracle.com
Tue Feb 11 03:38:31 EST 2014
> Why is this loop soo complicated? Why do you need to mess around with
> this "last_ep" stuff - you don't actually end up using it.
>
> The loop reduces down to this without comments:
>
> for (i = 0; !ret; i++) {
^^^^
Philipp, "ret" isn't set anymore in the new loop.
> uint32_t mask;
>
> ep = v4l2_of_get_next_endpoint(np, last_ep);
> if (!ep)
> break;
>
> /* CSI */
> mask = imx_drm_find_crtc_mask(imxdrm, ep);
> of_node_put(ep);
>
> if (mask == 0)
> return -EPROBE_DEFER;
>
> crtc_mask |= mask;
> }
regards,
dan carpenter
More information about the linux-arm-kernel
mailing list