Re: [PATCH] ARM: dts: i.MX51 babbage: Support diagnostic LED

[Alexander Shiyan]

Понедельник, 10 февраля 2014, 11:02 +08:00 от Shawn Guo <shawn.guo at linaro.org>:
> On Tue, Feb 04, 2014 at 09:57:42PM +0800, Liu Ying wrote:
> > The D25 LED controlled by gpio on the i.MX51 babbage
> > board is a diagnostic LED according to the board design.
> > This patch adds the relevant device tree nodes to the
> > i.MX51 babbage device tree file to support this LED.
> > 
> > Signed-off-by: Liu Ying <Ying.Liu at freescale.com>
> > ---
> >  arch/arm/boot/dts/imx51-babbage.dts |   17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx51-babbage.dts
> b/arch/arm/boot/dts/imx51-babbage.dts
> > index be1407c..8d6a74b 100644
> > --- a/arch/arm/boot/dts/imx51-babbage.dts
> > +++ b/arch/arm/boot/dts/imx51-babbage.dts
> > @@ -81,6 +81,17 @@
> >  		};
> >  	};
> >  
> > +	leds {
> > +		compatible = "gpio-leds";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&led_pin_gpio2_6>;
> > +
> > +		led-diagnostic {
> > +			label = "diagnostic";
> > +			gpios = <&gpio2 6 0>;
> 
> Just out of curiosity, how will you use/trigger the led?

And GPIO bindings should be used to specify active level,
GPIO_ACTIVE_HIGH in this case.

---