[PATCH 08/51] arm, hw-breakpoint: Fix CPU hotplug callback registration
will.deacon at arm.com
Thu Feb 6 05:57:18 EST 2014
On Wed, Feb 05, 2014 at 10:06:04PM +0000, Srivatsa S. Bhat wrote:
> Subsystems that want to register CPU hotplug callbacks, as well as perform
> initialization for the CPUs that are already online, often do it as shown
> This is wrong, since it is prone to ABBA deadlocks involving the
> cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently
> with CPU hotplug operations).
Hmm, the code in question (for this patch) runs from an arch_initcall. How
can you generate CPU hotplug operations at that stage?
> Instead, the correct and race-free way of performing the callback
> registration is:
> /* Note the use of the double underscored version of the API */
> Fix the hw-breakpoint code in arm by using this latter form of callback
I guess you introduce __register_cpu_notifier somewhere earlier in the
series, so it's best if you take this all via your tree.
More information about the linux-arm-kernel