[PATCH] arm64: fix early_io_map for 64K pages

Catalin Marinas catalin.marinas at arm.com
Wed Feb 5 09:55:19 EST 2014


On Wed, Feb 05, 2014 at 02:52:51PM +0000, Will Deacon wrote:
> On Wed, Feb 05, 2014 at 02:50:29PM +0000, Rob Herring wrote:
> > From: Rob Herring <robh at kernel.org>
> > 
> > earlyprintk is broken with 64KB pages. The problem is pgprot_default
> > is not yet initialized when early_io_map is called, so the pte does not
> > get marked as valid. Set the necessary page and access permission bits.
> > 
> > Cc: Mark Salter <msalter at redhat.com>
> > Cc: Catalin Marinas <catalin.marinas at arm.com>
> > Cc: Will Deacon <will.deacon at arm.com>
> > Signed-off-by: Rob Herring <robh at kernel.org>
> > ---
> 
> I thought we fixed this in 4ce00dfcf19c by reverting the use of
> pgprot_default?

Indeed. We still need to fix the ioremap_cache() case where the
shareability isn't set but I haven't yet decided what we do for
SMP-on-UP in arm64 (if we always assume SMP, I would just get rid of
pgprot_default entirely).

-- 
Catalin



More information about the linux-arm-kernel mailing list