[PATCH 08/18] mfd: max14577: Rename state container to maxim_core
Krzysztof Kozlowski
k.kozlowski at samsung.com
Wed Feb 5 05:48:16 EST 2014
+Cc: Chanwoo, Mark and Dmitry for ACK-s on their subsystems.
Krzysztof Kozlowski
On Mon, 2014-02-03 at 09:42 +0000, Lee Jones wrote:
> > This patch continues the preparation for adding support for max77836
> > device to existing max14577 driver.
> >
> > The patch renames the struct "max14577" state container to "maxim_core".
> > This is only a rename-like patch, new code is not added.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> > Cc: Kyungmin Park <kyungmin.park at samsung.com>
> > Cc: Marek Szyprowski <m.szyprowski at samsung.com>
> > ---
> > drivers/extcon/extcon-max14577.c | 22 +++++------
> > drivers/mfd/max14577.c | 68 +++++++++++++++++-----------------
> > drivers/power/max14577_charger.c | 16 ++++----
> > drivers/regulator/max14577.c | 6 +--
> > include/linux/mfd/max14577-private.h | 5 ++-
> > 5 files changed, 60 insertions(+), 57 deletions(-)
>
> Need some more maintainer Acks here.
>
> > -struct max14577 {
> > +/*
> > + * State container for max14577-like drivers.
> > + */
>
> I don't think this comment is required.
>
> Besides that, the code looks fine:
> Acked-by: Lee Jones <lee.jones at linaro.org>
>
> > +struct maxim_core {
> > struct device *dev;
> > struct i2c_client *i2c; /* Slave addr = 0x4A */
> >
>
More information about the linux-arm-kernel
mailing list