[PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone

Ivan Khoronzhuk ivan.khoronzhuk at ti.com
Tue Feb 4 11:54:52 EST 2014

It was so in v1. But it was decided to use explicit memory barriers,
because we're always sure the memory barriers are there and that
they're properly documented. Also in this case I don't need to add
keystone readl/writel relaxed function variants and to use mixed calls of
writel/writel_relaxed functions.


On 02/04/2014 06:24 PM, Thomas Gleixner wrote:
> On Tue, 4 Feb 2014, Ivan Khoronzhuk wrote:
>> +	keystone_timer_writel(off, TCR);
>> +	/* here we have to be sure the timer has been disabled */
>> +	wmb();
> We have explicit writew_relaxed and writew. Why open coding the
> barriers?
> Thanks,
> 	tglx

Ivan Khoronzhuk

More information about the linux-arm-kernel mailing list