[PATCH v5 08/14] ahci-platform: "Library-ise" suspend / resume functionality
Hans de Goede
hdegoede at redhat.com
Tue Feb 4 05:20:53 EST 2014
Hi,
On 02/03/2014 03:53 PM, Arnd Bergmann wrote:
> On Wednesday 22 January 2014, Hans de Goede wrote:
>> --- a/include/linux/ahci_platform.h
>> +++ b/include/linux/ahci_platform.h
>> @@ -50,4 +50,11 @@ int ahci_platform_init_host(struct platform_device *pdev,
>> unsigned int force_port_map,
>> unsigned int mask_port_map);
>>
>> +#ifdef CONFIG_PM_SLEEP
>> +int ahci_platform_suspend_host(struct device *dev);
>> +int ahci_platform_resume_host(struct device *dev);
>> +int ahci_platform_suspend(struct device *dev);
>> +int ahci_platform_resume(struct device *dev);
>> +#endif
>> +
>
> Not sure if the #ifdef does any good here. Normally, we don't hide declarations
> so we can do stuff like
Thanks for the review, I'll remove the #ifdef in the next version of this patch-set.
Regards,
Hans
More information about the linux-arm-kernel
mailing list