[PATCH 1/4] ARM: sirf: add two debug ports for CSRatlas7 SoC

[Barry Song]

2014-12-31 6:35 GMT+08:00 Arnd Bergmann <arnd at arndb.de>:
> On Thursday 25 December 2014 16:34:17 Barry Song wrote:
>>  #if defined(CONFIG_DEBUG_SIRFPRIMA2_UART1)
>> -#define SIRFSOC_UART1_PA_BASE          0xb0060000
>> +#define SIRF_LLUART_PA_BASE          0xb0060000
>>  #elif defined(CONFIG_DEBUG_SIRFMARCO_UART1)
>> -#define SIRFSOC_UART1_PA_BASE          0xcc060000
>> +#define SIRF_LLUART_PA_BASE          0xcc060000
>> +#elif defined(CONFIG_DEBUG_SIRFATLAS7_UART1)
>> +#define SIRF_LLUART_PA_BASE          0x18020000
>> +#elif defined(CONFIG_DEBUG_SIRFATLAS7_UART0)
>> +#define SIRF_LLUART_PA_BASE          0x18010000
>>  #else
>> -#define SIRFSOC_UART1_PA_BASE          0
>> +#define SIRF_LLUART_PA_BASE          0
>>  #endif
>
> I think it would be nicer to use DEBUG_UART_PHYS/DEBUG_UART_VIRT here.

yes if it is more general name for all. my second feeling is that does
this conflict CSR namespace stuff into high-level and common namespace
things?

>
>         Arnd

-barry