[PATCH v6 2/4] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy()
eric.dumazet at gmail.com
Tue Aug 26 03:55:30 PDT 2014
On Tue, 2014-08-26 at 09:10 +0000, David Laight wrote:
> From: Arnd Bergmann
> > While this seems correct, I wonder why you don't do the normal approach of
> > dequeuing the skb from the chain and adding a newly allocated skb to it to
> > save the memcpy.
> Because the receive buffer area isn't made of skbs.
> Post-allocating the skb also reduces the 'true size' of the skb.
This strategy assumes this is not a 10Gbe NIC.
We try to avoid copies because they are generally not needed.
Wifi devices are usually slow, and packet losses are more frequent, so
the copybreak gives better chance to not doing the collapses  later
in the TCP stack.
 collapses : reducing skb overhead (skb->len / skb->truesize ratio)
More information about the linux-arm-kernel