[PATCH 02/16] ARM: l2c: add platform independent core L2 cache initialisation

[Russell King - ARM Linux]

On Mon, Apr 28, 2014 at 01:50:33PM -0500, Rob Herring wrote:
> On Mon, Apr 28, 2014 at 1:23 PM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> > On Mon, Apr 28, 2014 at 12:54:58PM -0500, Rob Herring wrote:
> >> This function should be a nop if there is no DT node matching, so we
> >> don't really need to trigger calling it based on machine_desc values.
> >> If we do that, then we can have aux_mask and aux_val values of 0 for
> >> both also mean don't do any aux ctrl setup. That would help minimize
> >> the machine_desc for many platforms.
> >
> > Calling it with both set to zero results in the auxiliary control register
> > being cleared to zero.  We don't want that to happen.
> 
> Right, but we can make the core L2 init code only write aux ctrl if
> (aux_val && ~aux_mask). Then you don't have to add the values on a
> bunch of platforms.

I would rather add them right now rather than introduce new logic which
_could_ potentially change the behaviour for an existing platform.  Maybe
that's an improvement to come after this series is merged, but I'm already
up to almost 100 patches in this series right now, and I'll be damned if
I'm going to change the behaviour of this stuff even more as part of a
single series.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.