[PATCH 33/38] mmc: sdhci: fix SDHCI dependencies

Stephen Warren swarren at wwwdotorg.org
Mon Apr 28 09:28:49 PDT 2014


On 04/23/2014 01:08 PM, Russell King wrote:
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>

A patch description would be useful so I can work out why...

> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig

>  config MMC_SDHCI
> -	tristate "Secure Digital Host Controller Interface support"
> -	depends on HAS_DMA
> +	tristate
>  	help
>  	  This selects the generic Secure Digital Host Controller Interface.
>  	  It is used by manufacturers such as Texas Instruments(R), Ricoh(R)

... it's useful to remove that depends from here and ...
>  config MMC_SDHCI_TEGRA
>  	tristate "SDHCI platform support for the Tegra SD/MMC Controller"
> -	depends on ARCH_TEGRA
> -	depends on MMC_SDHCI_PLTFM
> +	depends on ARCH_TEGRA && HAS_DMA

... duplicate it in all the HW-specific drivers.

On Tegra (and I believe at least any ARM system), I think HAS_DMA is
always true, so is there a need for "&& HAS_DMA" at all, now that this
statement is pushed into arch-/HW-specific options?



More information about the linux-arm-kernel mailing list