[PATCH] clk: shmobile: clk-mstp: change to using clock-indices
Geert Uytterhoeven
geert at linux-m68k.org
Mon Apr 28 08:03:48 PDT 2014
Hi Wolfram,
On Mon, Apr 28, 2014 at 3:26 PM, Wolfram Sang <wsa at the-dreams.de> wrote:
>> + if (of_find_property(np, "clock-indices", &i))
>> + idxname = "clock-indices";
>> + else
>> + idxname = "renesas,clock-indices";
>
> ...and here in the code? It might also be a tad more intuitive to check
Thanks, a comment never hurts.
> for the depracted binding, and if not found, use the new one as default,
> i.e. switch the logic of the if block. Very minor nit, though.
I think checking for the new one first is the right thing to do.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsH
More information about the linux-arm-kernel
mailing list