[PATCH 1/2 v4] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

Naveen Krishna Ch naveenkrishna.ch at gmail.com
Mon Apr 28 01:15:54 PDT 2014

Hello Wolfram,

On 13 March 2014 00:48, Wolfram Sang <wsa at the-dreams.de> wrote:
> On Fri, Feb 07, 2014 at 10:12:51AM +0530, Naveen Krishna Chatradhi wrote:
>> This patch adds a new compatible and uses variant struct to support
>> HSI2C module on Exynos5260. Updates the Documentation dt bindings.
>> Also resets the module as an init sequence (Needed by Exynos5260).
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen at samsung.com>
> This patch has clearly not been tested :( Build failure!
comma was missing, Not sure, how i missed it.
Will fix it.
>> +struct exynos_hsi2c_variant {
>> +     unsigned int                fifo_depth;
>> +};
> Why so many tabs? In general, I'd prefer one space.
>> -     exynos5_i2c_init(i2c);
>> +     exynos5_i2c_reset(i2c);
> Is this a related change?
Exynos5260 needs the HSI2C module to be reset during the init.
As per Tomasz's comment on earlier version. We will reset the status
during init for every SoC.

Shine bright,
(: Nav :)

More information about the linux-arm-kernel mailing list