[PATCH 086/222] net:fec: ensure fec_enet_close() copes with resume failure
Russell King
rmk+kernel at arm.linux.org.uk
Fri Apr 25 04:38:16 PDT 2014
When the FEC is suspended, the device is detached. Upon resume failure,
the device is left in detached mode, possibly with some of the required
clocks not running. We don't want to be poking the device in that state
because as it may cause bus errors.
If the device is marked detached, avoid calling fec_stop().
This depends upon: "net:fec: improve safety of suspend/resume paths"
Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 843721aa44bd..f65c1f1d8770 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -1846,10 +1846,10 @@ fec_enet_close(struct net_device *ndev)
phy_stop(fep->phy_dev);
- /* Don't know what to do yet. */
napi_disable(&fep->napi);
netif_tx_disable(ndev);
- fec_stop(ndev);
+ if (netif_device_present(ndev))
+ fec_stop(ndev);
phy_disconnect(fep->phy_dev);
fep->phy_dev = NULL;
--
1.8.3.1
More information about the linux-arm-kernel
mailing list