[PATCH 3/3] pci: add DT based ARM Versatile PCI host driver

Rob Herring robherring2 at gmail.com
Thu Apr 24 16:37:20 PDT 2014


On Thu, Apr 24, 2014 at 6:24 PM, Bjorn Helgaas <bhelgaas at google.com> wrote:
> On Thu, Mar 27, 2014 at 05:46:38PM -0500, Rob Herring wrote:
>> From: Rob Herring <robh at kernel.org>
>>
>> This converts the Versatile PCI host code to a platform driver using
>> of_create_pci_host_bridge for parsing DT and setup.
>>
>> I think more of this setup could be done by the core code. There are
>> accesses to the host's config space (accesses using local_pci_cfg_base)
>> which seem like they could be done by the core code or using standard
>> config space accessors. The problem is bridge->bus->self is needed, but
>> it does not get setup. I'm not exactly sure how that should work.
>>
>> Signed-off-by: Rob Herring <robh at kernel.org>
>> Cc: Bjorn Helgaas <bhelgaas at google.com>
>> ...

>> +     bridge = of_create_pci_host_bridge(&pdev->dev, &pci_versatile_ops, &sys);
>
> Are we still relying on the PCI core to default to a bus number range of
> 00-ff?  Can we not do that?

No, that comes from DT.

Rob



More information about the linux-arm-kernel mailing list