[PATCH 4/7] pci: mvebu: fix off-by-one in the computed size of the mbus windows
jason at lakedaemon.net
Wed Apr 23 19:51:23 PDT 2014
On Mon, Apr 21, 2014 at 10:47:54AM -0600, Bjorn Helgaas wrote:
> On Fri, Apr 18, 2014 at 02:19:50PM +0200, Thomas Petazzoni wrote:
> > From: Willy Tarreau <w at 1wt.eu>
> > mvebu_pcie_handle_membase_change() and
> > mvebu_pcie_handle_iobase_change() do not correctly compute the window
> > size. PCI uses an inclusive start/end address pair, which requires a
> > +1 when converting to size.
> > This only worked because a bug in the mbus driver allowed it to
> > silently accept and round up bogus sizes.
> > Fix this by adding one to the computed size.
> > Fixes: 45361a4fe4464180815157654aabbd2afb4848ad ('PCIe driver for Marvell Armada 370/XP systems')
> > Cc: <stable at vger.kernel.org> # v3.11+
> > Signed-off-by: Willy Tarreau <w at 1wt.eu>
> > Reviewed-By: Jason Gunthorpe <jgunthorpe at obsidianresearch.com>
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> > Tested-by: Neil Greatorex <neil at fatboyfat.co.uk>
> Acked-by: Bjorn Helgaas <bhelgaas at google.com>
> If I were merging via my tree, I would tweak the subject capitalization
> so "git log --oneline drivers/pci/host/pci-mvebu.c" looks consistent.
Will do, thanks for the reminder.
More information about the linux-arm-kernel