[PATCH 35/38] mmc: dw_mmc: call mmc_of_parse to fill in common options
jh80.chung at samsung.com
Wed Apr 23 17:31:54 PDT 2014
I didn't know which version you have checked.
But I have known that mmc_of_parse() have already included at mmc-next repository.
Author: Jaehoon Chung <jh80.chung at gmail.com>
Date: Mon Mar 3 11:36:41 2014 +0900
mmc: dw_mmc: use the mmc_of_parse() instead of local parser
mmc_of_parse() have been already parsed the general capability.
Didn't need to use the local parser.
Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
Acked-by: Seungwon Jeon <tgih.jun at samsung.com>
Signed-off-by: Ulf Hansson <ulf.hansson at linaro.org>
Signed-off-by: Chris Ball <chris at printf.net>
Could you check it, plz?
On 04/24/2014 04:09 AM, Russell King wrote:
> From: Olof Johansson <olof at lixom.net>
> The shared of parse function fills in common options for capabilities,
> etc, but it needs to be called from each driver that wants to make use
> of it. dw_mmc was missing the call.
> Signed-off-by: Olof Johansson <olof at lixom.net>
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> drivers/mmc/host/dw_mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index cced599d5aeb..a2c12ebb376e 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2140,6 +2140,8 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
> if (!mmc)
> return -ENOMEM;
> + mmc_of_parse(mmc);
> slot = mmc_priv(mmc);
> slot->id = id;
> slot->mmc = mmc;
More information about the linux-arm-kernel