[PATCH 4/4] pinctrl: sirf: move to use irq_get_handler_data

Barry Song 21cnbao at gmail.com
Wed Apr 23 15:59:29 PDT 2014


2014-04-24 4:17 GMT+08:00 Linus Walleij <linus.walleij at linaro.org>:
> On Tue, Apr 15, 2014 at 8:43 AM, Barry Song <21cnbao at gmail.com> wrote:
>
>> From: Barry Song <Baohua.Song at csr.com>
>>
>> we set bank as handler_data, now we can get bank in ISR directly
>> instead of looking-up.
>>
>> Signed-off-by: Barry Song <Baohua.Song at csr.com>
>
> If you want to use some other handler data than the gpiochip,
> you should just use irq_set_chained_handler() and
> irq_set_handler_data() directly.

i think this should be fixed in the general API but not use one more
function call to over-write the handler_data which has been filled in
the API.
since we have the chance for drivers to set either the whole chip for
a simple chip,  or bank-specific data for a chip which has multiple
parent IRQs.

>
> Yours,
> Linus Walleij

-barry



More information about the linux-arm-kernel mailing list