[PATCH] pinctrl/at91: convert driver to use gpiolib irqchip

Linus Walleij linus.walleij at linaro.org
Tue Apr 22 14:39:38 PDT 2014


On Tue, Apr 15, 2014 at 10:09 PM, Alexander Stein <alexanders83 at web.de> wrote:

> This converts the AT91 pin control driver to register its
> chained irq handler and irqchip using the helpers in the
> gpiolib core.
>
> Signed-off-by: Alexander Stein <alexanders83 at web.de>

Part of the large attempt to pull all these local hacks into the
gpiolib irqchip helpers so patch applied. Any further quarrels
can be solved on top of this in the *generic* code.

I changed this:

> +static void gpio_orq_ack(struct irq_data *d)
> +{
> +       /* the interrupt is already cleared before by reading ISR */
> +}
> +
>  static unsigned int gpio_irq_startup(struct irq_data *d)
>  {
>         struct at91_gpio_chip *at91_gpio = irq_data_get_irq_chip_data(d);
> @@ -1434,6 +1420,7 @@ void at91_pinctrl_gpio_resume(void)
>
>  static struct irq_chip gpio_irqchip = {
>         .name           = "GPIO",
> +       .irq_ack        = gpio_orq_ack,

orq? I didn't get it so changed to irq when applying.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list