[PATCH 11/11] pinctrl: single: Clear pin interrupts enabled by bootloader

Tony Lindgren tony at atomide.com
Tue Apr 22 09:10:33 PDT 2014


* Linus Walleij <linus.walleij at linaro.org> [140422 04:55]:
> On Fri, Apr 11, 2014 at 1:47 AM, Tony Lindgren <tony at atomide.com> wrote:
> 
> > Since we set up device wake-up interrupts as pinctrl-single
> > interrupts, we now must use the standard request_irq and
> > related functions to manage them.
> >
> > If the pin interrupts are enabled for some pins at boot,
> > the wake-up events can show up as constantly pending
> > at least on omaps and will hang the system unless the related
> > device driver clears the event at the device.
> >
> > To fix this, let's clear the interrupt flags during init,
> > and print out a warning so the board maintainers can update
> > their drivers to do proper request_irq for the driver specific
> > wake-up events.
> >
> > Cc: Haojian Zhuang <haojian.zhuang at linaro.org>
> > Cc: Linus Walleij <linus.walleij at linaro.org>
> > Signed-off-by: Tony Lindgren <tony at atomide.com>
> 
> Looks clean.
> 
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
> 
> Shall I apply this patch or will you funnel it through ARM SoC
> due to deps?

No deps except boards hanging without it.. Please feel free to
take this one, prererrably as a fix for the -rc series if no
objections.

Regards,

Tony



More information about the linux-arm-kernel mailing list