[PATCH 1/2] phy: samsung: add simple phys for exynos5250 SoC

[Sachin Kamat]

Hi Rahul,

On 20 April 2014 15:38, Rahul Sharma <rahul.sharma at samsung.com> wrote:
> From: Rahul Sharma <Rahul.Sharma at samsung.com>
>
> Extend the support for simple phys for exynos5250 SoC
> in simple phy driver.
>
> Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130
> ---
>  .../devicetree/bindings/phy/samsung-phy.txt        |   22 ++++++++++++++++++++
>  drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
>  2 files changed, 31 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> index f97c4c3..f469099 100644
> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> @@ -122,6 +122,7 @@ Required properties:
>  - compatible : should be one of the listed compatibles:
>         - "samsung,exynos4210-simple-phy"
>         - "samsung,exynos4412-simple-phy"
> +       - "samsung,exynos5250-simple-phy"
>  - reg : offset and length of the register set;
>  - #phy-cells : from the generic phy bindings, must be 1;
>
> @@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows:
>    0 - HDMI PHY,
>    1 - ADC PHY,
>
> +For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
> +the PHY specifier identifies the PHY and its meaning is as follows:
> +  0 - HDMI PHY,
> +  1 - ADC PHY,
> +  2 - ADC PHY,

What is the difference between 1 and 2? Probably it should be SATA?

> +
> +Example:
> +Simple PHY provider node:
> +
> +       simplephys: simple-phys at 10040000 {
> +               compatible = "samsung,exynos5250-simple-phy";
> +               reg = <0x10040000 0x10000>;
> +               #phy-cells = <1>;
> +       };
> +
> +Other nodes accessing simple PHYs:
> +
> +       hdmi {
> +               phys = <&simplephys 0>;
> +               phy-names = "hdmiphy";
> +       };
> diff --git a/drivers/phy/exynos-simple-phy.c b/drivers/phy/exynos-simple-phy.c
> index 57ad338..187f6b1 100644
> --- a/drivers/phy/exynos-simple-phy.c
> +++ b/drivers/phy/exynos-simple-phy.c
> @@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
>         ~0, /* end mark */
>  };
>
> +static const u32 exynos5250_offsets[] = {
> +       0x0700, /* HDMI_PHY */
> +       0x0718, /* ADC_PHY */
> +       0x0724, /* SATA_PHY */
> +       ~0, /* end mark */
> +};
> +



-- 
With warm regards,
Sachin