[PATCH 1/4] ARM: Kirkwood: Add board file for netxbig LEDs
Jason Cooper
jason at lakedaemon.net
Fri Apr 18 06:21:48 PDT 2014
On Thu, Apr 17, 2014 at 06:08:55PM +0200, Andrew Lunn wrote:
> There is currently no DT binding for the CPLD which controls the LEDs
> on the Net 2Big and Net 5Big. So use a platform device.
>
> Signed-off-by: Andrew Lunn <andrew at lunn.ch>
> ---
> arch/arm/mach-mvebu/Kconfig | 7 ++
> arch/arm/mach-mvebu/Makefile | 1 +
> arch/arm/mach-mvebu/board-netxbig.c | 191 ++++++++++++++++++++++++++++++++++++
This seems pretty simple. What's preventing this from becoming a
full-fledged driver under drivers/leds?
If this were a driver that's critical for boot, I could see moving it
in soc code, but it's not. What's you're plan here?
thx,
Jason.
> arch/arm/mach-mvebu/board.h | 6 ++
> arch/arm/mach-mvebu/kirkwood.c | 3 +
> 5 files changed, 208 insertions(+)
> create mode 100644 arch/arm/mach-mvebu/board-netxbig.c
>
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 3f73eecbcfb0..711ffd4fef85 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -97,6 +97,13 @@ config MACH_KIRKWOOD
> Say 'Y' here if you want your kernel to support boards based
> on the Marvell Kirkwood device tree.
>
> +config MACH_NETXBIG
> + bool "LaCie 2Big and 5Big Network v2"
> + depends on MACH_KIRKWOOD
> + help
> + Say 'Y' here if you want your kernel to support the
> + LaCie 2Big and 5Big Network v2
> +
> config MACH_T5325
> bool "HP T5325 thin client"
> depends on MACH_KIRKWOOD
> diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
> index a63e43b6b451..014f32d87ebd 100644
> --- a/arch/arm/mach-mvebu/Makefile
> +++ b/arch/arm/mach-mvebu/Makefile
> @@ -10,4 +10,5 @@ obj-$(CONFIG_ARCH_MVEBU) += coherency.o coherency_ll.o pmsu.o
> obj-$(CONFIG_SMP) += platsmp.o headsmp.o
> obj-$(CONFIG_HOTPLUG_CPU) += hotplug.o
> obj-$(CONFIG_MACH_KIRKWOOD) += kirkwood.o kirkwood-pm.o
> +obj-$(CONFIG_MACH_NETXBIG) += board-netxbig.o
> obj-$(CONFIG_MACH_T5325) += board-t5325.o
> diff --git a/arch/arm/mach-mvebu/board-netxbig.c b/arch/arm/mach-mvebu/board-netxbig.c
> new file mode 100644
> index 000000000000..e6f2f547b1c7
> --- /dev/null
> +++ b/arch/arm/mach-mvebu/board-netxbig.c
> @@ -0,0 +1,191 @@
> +/*
> + * arch/arm/mach-mvbu/board-netxbig.c
> + *
> + * LaCie 2Big and 5Big Network v2 board setup
> + *
> + * Copyright (C) 2010 Simon Guinot <sguinot at lacie.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/platform_data/leds-kirkwood-netxbig.h>
> +#include "common.h"
> +
> +/*****************************************************************************
> + * GPIO extension LEDs
> + ****************************************************************************/
> +
> +/*
> + * The LEDs are controlled by a CPLD and can be configured through a GPIO
> + * extension bus:
> + *
> + * - address register : bit [0-2] -> GPIO [47-49]
> + * - data register : bit [0-2] -> GPIO [44-46]
> + * - enable register : GPIO 29
> + */
> +
> +static int netxbig_v2_gpio_ext_addr[] = { 47, 48, 49 };
> +static int netxbig_v2_gpio_ext_data[] = { 44, 45, 46 };
> +
> +static struct netxbig_gpio_ext netxbig_v2_gpio_ext = {
> + .addr = netxbig_v2_gpio_ext_addr,
> + .num_addr = ARRAY_SIZE(netxbig_v2_gpio_ext_addr),
> + .data = netxbig_v2_gpio_ext_data,
> + .num_data = ARRAY_SIZE(netxbig_v2_gpio_ext_data),
> + .enable = 29,
> +};
> +
> +/*
> + * Address register selection:
> + *
> + * addr | register
> + * ----------------------------
> + * 0 | front LED
> + * 1 | front LED brightness
> + * 2 | SATA LED brightness
> + * 3 | SATA0 LED
> + * 4 | SATA1 LED
> + * 5 | SATA2 LED
> + * 6 | SATA3 LED
> + * 7 | SATA4 LED
> + *
> + * Data register configuration:
> + *
> + * data | LED brightness
> + * -------------------------------------------------
> + * 0 | min (off)
> + * - | -
> + * 7 | max
> + *
> + * data | front LED mode
> + * -------------------------------------------------
> + * 0 | fix off
> + * 1 | fix blue on
> + * 2 | fix red on
> + * 3 | blink blue on=1 sec and blue off=1 sec
> + * 4 | blink red on=1 sec and red off=1 sec
> + * 5 | blink blue on=2.5 sec and red on=0.5 sec
> + * 6 | blink blue on=1 sec and red on=1 sec
> + * 7 | blink blue on=0.5 sec and blue off=2.5 sec
> + *
> + * data | SATA LED mode
> + * -------------------------------------------------
> + * 0 | fix off
> + * 1 | SATA activity blink
> + * 2 | fix red on
> + * 3 | blink blue on=1 sec and blue off=1 sec
> + * 4 | blink red on=1 sec and red off=1 sec
> + * 5 | blink blue on=2.5 sec and red on=0.5 sec
> + * 6 | blink blue on=1 sec and red on=1 sec
> + * 7 | fix blue on
> + */
> +
> +static int netxbig_v2_red_mled[NETXBIG_LED_MODE_NUM] = {
> + [NETXBIG_LED_OFF] = 0,
> + [NETXBIG_LED_ON] = 2,
> + [NETXBIG_LED_SATA] = NETXBIG_LED_INVALID_MODE,
> + [NETXBIG_LED_TIMER1] = 4,
> + [NETXBIG_LED_TIMER2] = NETXBIG_LED_INVALID_MODE,
> +};
> +
> +static int netxbig_v2_blue_pwr_mled[NETXBIG_LED_MODE_NUM] = {
> + [NETXBIG_LED_OFF] = 0,
> + [NETXBIG_LED_ON] = 1,
> + [NETXBIG_LED_SATA] = NETXBIG_LED_INVALID_MODE,
> + [NETXBIG_LED_TIMER1] = 3,
> + [NETXBIG_LED_TIMER2] = 7,
> +};
> +
> +static int netxbig_v2_blue_sata_mled[NETXBIG_LED_MODE_NUM] = {
> + [NETXBIG_LED_OFF] = 0,
> + [NETXBIG_LED_ON] = 7,
> + [NETXBIG_LED_SATA] = 1,
> + [NETXBIG_LED_TIMER1] = 3,
> + [NETXBIG_LED_TIMER2] = NETXBIG_LED_INVALID_MODE,
> +};
> +
> +static struct netxbig_led_timer netxbig_v2_led_timer[] = {
> + [0] = {
> + .delay_on = 500,
> + .delay_off = 500,
> + .mode = NETXBIG_LED_TIMER1,
> + },
> + [1] = {
> + .delay_on = 500,
> + .delay_off = 1000,
> + .mode = NETXBIG_LED_TIMER2,
> + },
> +};
> +
> +#define NETXBIG_LED(_name, maddr, mval, baddr) \
> + { .name = _name, \
> + .mode_addr = maddr, \
> + .mode_val = mval, \
> + .bright_addr = baddr }
> +
> +static struct netxbig_led net2big_v2_leds_ctrl[] = {
> + NETXBIG_LED("net2big-v2:blue:power", 0, netxbig_v2_blue_pwr_mled, 1),
> + NETXBIG_LED("net2big-v2:red:power", 0, netxbig_v2_red_mled, 1),
> + NETXBIG_LED("net2big-v2:blue:sata0", 3, netxbig_v2_blue_sata_mled, 2),
> + NETXBIG_LED("net2big-v2:red:sata0", 3, netxbig_v2_red_mled, 2),
> + NETXBIG_LED("net2big-v2:blue:sata1", 4, netxbig_v2_blue_sata_mled, 2),
> + NETXBIG_LED("net2big-v2:red:sata1", 4, netxbig_v2_red_mled, 2),
> +};
> +
> +static struct netxbig_led_platform_data net2big_v2_leds_data = {
> + .gpio_ext = &netxbig_v2_gpio_ext,
> + .timer = netxbig_v2_led_timer,
> + .num_timer = ARRAY_SIZE(netxbig_v2_led_timer),
> + .leds = net2big_v2_leds_ctrl,
> + .num_leds = ARRAY_SIZE(net2big_v2_leds_ctrl),
> +};
> +
> +static struct netxbig_led net5big_v2_leds_ctrl[] = {
> + NETXBIG_LED("net5big-v2:blue:power", 0, netxbig_v2_blue_pwr_mled, 1),
> + NETXBIG_LED("net5big-v2:red:power", 0, netxbig_v2_red_mled, 1),
> + NETXBIG_LED("net5big-v2:blue:sata0", 3, netxbig_v2_blue_sata_mled, 2),
> + NETXBIG_LED("net5big-v2:red:sata0", 3, netxbig_v2_red_mled, 2),
> + NETXBIG_LED("net5big-v2:blue:sata1", 4, netxbig_v2_blue_sata_mled, 2),
> + NETXBIG_LED("net5big-v2:red:sata1", 4, netxbig_v2_red_mled, 2),
> + NETXBIG_LED("net5big-v2:blue:sata2", 5, netxbig_v2_blue_sata_mled, 2),
> + NETXBIG_LED("net5big-v2:red:sata2", 5, netxbig_v2_red_mled, 2),
> + NETXBIG_LED("net5big-v2:blue:sata3", 6, netxbig_v2_blue_sata_mled, 2),
> + NETXBIG_LED("net5big-v2:red:sata3", 6, netxbig_v2_red_mled, 2),
> + NETXBIG_LED("net5big-v2:blue:sata4", 7, netxbig_v2_blue_sata_mled, 2),
> + NETXBIG_LED("net5big-v2:red:sata5", 7, netxbig_v2_red_mled, 2),
> +};
> +
> +static struct netxbig_led_platform_data net5big_v2_leds_data = {
> + .gpio_ext = &netxbig_v2_gpio_ext,
> + .timer = netxbig_v2_led_timer,
> + .num_timer = ARRAY_SIZE(netxbig_v2_led_timer),
> + .leds = net5big_v2_leds_ctrl,
> + .num_leds = ARRAY_SIZE(net5big_v2_leds_ctrl),
> +};
> +
> +static struct platform_device netxbig_v2_leds = {
> + .name = "leds-netxbig",
> + .id = -1,
> + .dev = {
> + .platform_data = &net2big_v2_leds_data,
> + },
> +};
> +
> +void __init netxbig_init(void)
> +{
> +
> + if (of_machine_is_compatible("lacie,net5big"))
> + netxbig_v2_leds.dev.platform_data = &net5big_v2_leds_data;
> + platform_device_register(&netxbig_v2_leds);
> +}
> diff --git a/arch/arm/mach-mvebu/board.h b/arch/arm/mach-mvebu/board.h
> index de7f0a191394..f130d8079b68 100644
> --- a/arch/arm/mach-mvebu/board.h
> +++ b/arch/arm/mach-mvebu/board.h
> @@ -19,4 +19,10 @@ void t5325_init(void);
> static inline void t5325_init(void) {};
> #endif
>
> +#ifdef CONFIG_MACH_NETXBIG
> +void netxbig_init(void);
> +#else
> +static inline void netxbig_init(void) {};
> +#endif
> +
> #endif
> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
> index 120207fc36f1..c0b4828970fc 100644
> --- a/arch/arm/mach-mvebu/kirkwood.c
> +++ b/arch/arm/mach-mvebu/kirkwood.c
> @@ -183,6 +183,9 @@ static void __init kirkwood_dt_init(void)
> if (of_machine_is_compatible("hp,t5325"))
> t5325_init();
>
> + if (of_machine_is_compatible("lacie,netxbig"))
> + netxbig_init();
> +
> of_platform_populate(NULL, of_default_bus_match_table, auxdata, NULL);
> }
>
> --
> 1.9.2
>
More information about the linux-arm-kernel
mailing list