[PATCH v5 08/20] ARM: shmobile: r8a7779: Add helper to read mode pins

[Simon Horman]

On Wed, Apr 16, 2014 at 09:29:33AM +0200, Geert Uytterhoeven wrote:
> On Wed, Apr 16, 2014 at 3:57 AM, Simon Horman
> <horms+renesas at verge.net.au> wrote:
> > Add and use helper to read mode pins.
> > This will be re-used when moving marzen-reference to
> > the common clock framework.
> >
> > Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> 
> Acked-by: Geert Uytterhoeven <geert at linux-m68k.org>
> 
> > --- a/arch/arm/mach-shmobile/setup-r8a7779.c
> > +++ b/arch/arm/mach-shmobile/setup-r8a7779.c
> > @@ -802,6 +802,20 @@ void __init r8a7779_add_standard_devices_dt(void)
> >         of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> >  }
> >
> > +#define MODEMR         0xffcc0020
> > +
> > +u32 __init r8a7779_read_mode_pins(void)
> > +{
> > +       void __iomem *modemr = ioremap_nocache(MODEMR, PAGE_SIZE);
> > +       u32 mode;
> > +
> > +       BUG_ON(!modemr);
> > +       mode = ioread32(modemr);
> > +       iounmap(modemr);
> > +
> > +       return mode;
> > +}
> 
> No caching, cfr. rcar_gen2_read_mode_pins()?

I have one question about caching, which IIRC you
implemented for R-Car Gen 2. Is the code called often enough
that it makes any difference?

> 
> BTW, I know you don't trust "R-Car Gen1" similarities, but the code for
> r8a7778 is identical. And this is code, not DT, so perhaps this can be
> rcar_gen_read_mode_pins() in arch/arm/mach-shmobile/setup-rcar-gen1.c?

Yes, I agree that is a good idea.
But I think its best done as a next-step.