[PATCH] ARM: dts: imx27-pdk: Add PMIC support

[Fabio Estevam]

On Tue, Apr 15, 2014 at 6:58 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Tue, Apr 15, 2014 at 06:55:12PM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam at freescale.com>
>>
>> imx27-pdk has a MC13783 PMIC connected to CSPI2 port.
>>
>> Add support for it.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>
> The issue I referred to in my reply to your oops does still need fixing
> (and testing whether it fixes the oops.)
>
> It's really not on to code drivers such that it's possible to use
> resources before they are initialised.  That means mutexes and locks
> must be initialised before requesting (threaded) IRQs if they're used
> by those functions.
>
> In your case, that mutex *definitely* needs initialisation before the
> threaded IRQ handler is requested.

Yes, I agree. I will look at it.

The dt file I sent initially had the wrong SPI port connected to the PMIC.

The PMIC is connected to SPI2 (spi1 in Linux), not SPI1 (spi0 in Linux).

Now it probes correctly, but yes, I will address the issue you raised.

Thanks,

Fabio Estevam