[PATCH 1/2] ahci: imx: use macros to define registers and bits
Tejun Heo
tj at kernel.org
Tue Apr 15 09:03:17 PDT 2014
On Tue, Apr 15, 2014 at 10:41:42AM +0800, Shawn Guo wrote:
> Comparing to enums, macros are more conventional to be used for
> registers and bits definition. Let's switch to macros.
>
> While at it, the names of the registers and bit-fields are updated to
> have proper namespace prefix and match the hardware reference manual.
>
> No functional change is involved.
>
> Signed-off-by: Shawn Guo <shawn.guo at freescale.com>
Please don't switch to defines. A lot of libata constants use enums
and they tend to have more advantages anyway.
Thanks.
--
tejun
More information about the linux-arm-kernel
mailing list