[PATCH] clk: sirf: fix a bundle of checkpatch issues

Barry Song 21cnbao at gmail.com
Tue Apr 15 02:10:59 PDT 2014


2014-04-15 13:01 GMT+08:00 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> Hello,
>
> On Tue, Apr 15, 2014 at 10:40:03AM +0800, Barry Song wrote:
>> From: Bin Shi <Bin.Shi at csr.com>
>> diff --git a/drivers/clk/sirf/clk-atlas6.c b/drivers/clk/sirf/clk-atlas6.c
>> index d63b76c..b068feb 100644
>> --- a/drivers/clk/sirf/clk-atlas6.c
>> +++ b/drivers/clk/sirf/clk-atlas6.c
>> @@ -60,10 +60,10 @@ static struct clk_dmn clk_nand = {
>>
>>  enum atlas6_clk_index {
>>       /* 0    1     2      3      4      5      6       7         8      9 */
>> -     rtc,    osc,   pll1,  pll2,  pll3,  mem,   sys,   security, dsp,   gps,
>> -     mf,     io,    cpu,   uart0, uart1, uart2, tsc,   i2c0,     i2c1,  spi0,
>> -     spi1,   pwmc,  efuse, pulse, dmac0, dmac1, nand,  audio,    usp0,  usp1,
>> -     usp2,   vip,   gfx,   gfx2d,    lcd,   vpp,   mmc01, mmc23,    mmc45, usbpll,
>> +     rtc,  osc,   pll1,  pll2,  pll3,  mem,   sys,   security, dsp,   gps,
>> +     mf,   io,    cpu,   uart0, uart1, uart2, tsc,   i2c0,     i2c1,  spi0,
>> +     spi1, pwmc,  efuse, pulse, dmac0, dmac1, nand,  audio,    usp0,  usp1,
>> +     usp2, vip,   gfx,   gfx2d, lcd,   vpp,   mmc01, mmc23,    mmc45, usbpll,
>>       usb0,  usb1,   cphif, maxclk,
> Here only the indention is changed, right? I wonder why the last line
> was not fixed to be aligned with the others.

careful enough, thanks! we can fix that by:
diff --git a/drivers/clk/sirf/clk-atlas6.c b/drivers/clk/sirf/clk-atlas6.c
index b068feb..bca0052 100644
--- a/drivers/clk/sirf/clk-atlas6.c
+++ b/drivers/clk/sirf/clk-atlas6.c
@@ -59,12 +59,12 @@ static struct clk_dmn clk_nand = {
 };

 enum atlas6_clk_index {
-       /* 0    1     2      3      4      5      6       7         8      9 */
-       rtc,  osc,   pll1,  pll2,  pll3,  mem,   sys,   security, dsp,   gps,
-       mf,   io,    cpu,   uart0, uart1, uart2, tsc,   i2c0,     i2c1,  spi0,
-       spi1, pwmc,  efuse, pulse, dmac0, dmac1, nand,  audio,    usp0,  usp1,
-       usp2, vip,   gfx,   gfx2d, lcd,   vpp,   mmc01, mmc23,    mmc45, usbpll,
-       usb0,  usb1,   cphif, maxclk,
+       /* 0    1     2      3      4      5      6       7       8      9 */
+       rtc,  osc,  pll1,  pll2,  pll3,  mem,   sys,   security, dsp,   gps,
+       mf,   io,   cpu,   uart0, uart1, uart2, tsc,   i2c0,     i2c1,  spi0,
+       spi1, pwmc, efuse, pulse, dmac0, dmac1, nand,  audio,    usp0,  usp1,
+       usp2, vip,  gfx,   gfx2d, lcd,   vpp,   mmc01, mmc23,    mmc45, usbpll,
+       usb0, usb1, cphif, maxclk,
 };


>
> Best regards
> Uwe

-barry



More information about the linux-arm-kernel mailing list