[rtc-linux] [PATCH] rtc: Fix suspend/resume for APM X-Gene SoC RTC driver

Loc Ho lho at apm.com
Mon Apr 14 10:52:41 PDT 2014


Hi,

>> -     clk_prepare_enable(pdata->clk);
>> +     ret = clk_prepare_enable(pdata->clk);
>> +     if (ret)
>> +             return ret;
>>
>>       /* Turn on the clock and the crystal */
>>       writel(RTC_CCR_EN, pdata->csr_base + RTC_CCR);
>>
>> -     device_init_wakeup(&pdev->dev, 1);
>> +     ret = device_init_wakeup(&pdev->dev, 1);
>> +     if (ret)
>> +             return ret;
>>
> If the init fails you should unprepare (though I suspect the same issue
> applies to other things in the probe function anyway).  If you fix that
> then feel free to add:
>

Okay... This is the only place missed. I don't see issue with other
locations. I will post another version soon.

-Loc



More information about the linux-arm-kernel mailing list