[PATCH] ARM: VFP: Fix emulation of multiply accumulate instructions

Jay Foad jay.foad at gmail.com
Mon Apr 14 08:26:49 PDT 2014


On 8 April 2014 14:13, Dave Martin <Dave.Martin at arm.com> wrote:
> On Wed, Mar 26, 2014 at 04:49:09PM +0000, Jay Foad wrote:
>> The emulation for single and double precision multiply accumulate
>> instructions correctly normalised any denormal values in the operand
>> registers, but failed to normalise the destination (accumulator)
>> register.
>>
>> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=70501
>>
>> Signed-off-by: Jay Foad <jay.foad at gmail.com>
>
> Reviewed-by: Dave Martin <Dave.Martin at arm.com>
>
> This appears to be clean and straightforward, so if nobody else has
> commented on this by the time -rc1 comes out, I suggest you rebase it
> and send it to the patch system.  (See
> http://www.arm.linux.org.uk/developer/patches/info.php for details
> -- make sure you read it carefully.)

Done.

> Has this issue been hitting real-world users of the kernel, or is
> this fixing a latent bug?

Real world: it was causing failures in the test suite for an APL
interpreter running on the Raspberry Pi.

Thanks,
Jay.



More information about the linux-arm-kernel mailing list