commit b3a977b224 {ARM: Better virt_to_page() handling} breaks Keystone boot

Santosh Shilimkar santosh.shilimkar at ti.com
Mon Apr 14 06:36:47 PDT 2014


On Saturday 12 April 2014 04:46 AM, Russell King - ARM Linux wrote:
> On Fri, Apr 11, 2014 at 09:16:40PM -0400, Santosh Shilimkar wrote:
>> +	if (mem_start < KEYSTONE_HIGH_PHYS_START ||
>> +	    mem_end   > KEYSTONE_HIGH_PHYS_END) {
>> +		pr_crit("Invalid address space for memory (%08llx-%08llx)\n",
>> +		      (u64)mem_start, (u64)mem_end);
>> +	}
>> +
>> +	offset += KEYSTONE_HIGH_PHYS_START;
>> +	__pv_phys_offset = offset;
> 
> Right, so this will create a link error, and needs to become:
> 
Yep and I did fix that by using __pv_phys_pfn_offset

> 	__pv_phys_pfn_offset = offset >> PAGE_SHIFT;
> 
But I missed to convert it to pfn and that was the issue.
Thanks.

Regards,
Santosh



More information about the linux-arm-kernel mailing list