[PATCH 21/29] ARM: orion5x: use DT to describe I2C devices on edmini_v2

Andrew Lunn andrew at lunn.ch
Sun Apr 13 08:53:58 PDT 2014


On Sun, Apr 13, 2014 at 05:43:41PM +0200, Thomas Petazzoni wrote:
> Dear Andrew Lunn,
> 
> On Sun, 13 Apr 2014 17:28:40 +0200, Andrew Lunn wrote:
> 
> > > +			i2c at 11000 {
> > > +				status = "okay";
> > > +				clock-frequency = <100000>;
> > > +				#address-cells = <1>;
> > > +
> > > +				rtc at 32 {
> > > +					compatible = "rs5c372a";
> > 
> > Hi Thomas
> > 
> > This should have a vendor prefix.
> 
> Ok, I was afraid this would have required adding an explicit DT binding
> to the RTC driver, but that's not the case: of_modalias_node() strips
> the vendor part of the compatible string.

Yep, the vendor prefix is totally ignored, except by checkpatch, which
i guess is giving you a warning. It is also nice to have the prefix
just to be consistent, and maybe *BSD wants the prefix?

     Andrew



More information about the linux-arm-kernel mailing list