Re: [PATCH 02/10] ARM: dts: imx51-babbage: Use separate pingroup for fixed-clock

[Alexander Shiyan]

Sun, 13 Apr 2014 16:18:07 +0800 от Shawn Guo <shawn.guo at freescale.com>:
> On Sun, Apr 13, 2014 at 09:19:05AM +0400, Alexander Shiyan wrote:
> > This patch moves GPIOs definitions for "fixed-clock" into a separate
> > pingroup.
> > 
> > Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> > ---
> >  arch/arm/boot/dts/imx51-babbage.dts | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
> > index eddb62d..651a8c8 100644
> > --- a/arch/arm/boot/dts/imx51-babbage.dts
> > +++ b/arch/arm/boot/dts/imx51-babbage.dts
> > @@ -125,6 +125,8 @@
> >  
> >  		clk_26M: codec_clock {
> >  			compatible = "fixed-clock";
> > +			pinctrl-names = "default";
> > +			pinctrl-0 = <&pinctrl_clkcodec>;
> 
> Are you sure that pinctrl-* settings work for a fixed-clock?  My
> impression is that it only works for the device that Linux creates
> struct device and probes for.

Hmm, you are right.
In this case, it would be logical to move the pinctrl definition for this GPIO
to the codec node.

---