[PATCH] pinctrl/at91: Fix pin_to_mask

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Fri Apr 11 08:42:19 PDT 2014


On Apr 11, 2014, at 11:35 PM, Alexander Stein <alexanders83 at web.de> wrote:

> 
> We need first to reduce the pin number to only a GPIO bank before we can
> create the mask.
> Otherwise only GPIO bank 0 has correct masks as the bits in the other
> banks are shifted out of range.
> 
> Signed-off-by: Alexander Stein <alexanders83 at web.de>
> ---
> drivers/pinctrl/pinctrl-at91.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 63176f2..6669e13 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -316,7 +316,7 @@ static inline int pin_to_bank(unsigned pin)
> 
> static unsigned pin_to_mask(unsigned int pin)
> {
> -	return 1 << pin;
> +	return 1 << (pin % MAX_NB_GPIO_PER_BANK);
> }
no need pin_to_mask is already called with it
> 
> 
> static void at91_mux_disable_interrupt(void __iomem *pio, unsigned mask)
> -- 
> 1.9.2
> 




More information about the linux-arm-kernel mailing list