[RFC PATCH] uprobes: copy to user-space xol page with proper cache flushing

Oleg Nesterov oleg at redhat.com
Fri Apr 11 06:08:49 PDT 2014


On 04/10, David Long wrote:
>
>  static void copy_to_page(struct page *page, unsigned long vaddr, const void *src, int len)
>  {
>  	void *kaddr = kmap_atomic(page);
> -	memcpy(kaddr + (vaddr & ~PAGE_MASK), src, len);
> +	copy_to_user_page(NULL, page, vaddr, kaddr + (vaddr & ~PAGE_MASK), src, len);

No, no, this is not what we want... And I do not think we should change
copy_to_user_page().

I'll write another email...

Oleg.




More information about the linux-arm-kernel mailing list