[PATCH 01/11] ARM: OMAP3: PM: remove access to PRM_VOLTCTRL register

Tony Lindgren tony at atomide.com
Thu Apr 10 16:47:09 PDT 2014


From: Tero Kristo <t-kristo at ti.com>

There is a solitary write to this register every wakeup from off-mode,
which isn't doing anything, so remove it.

Also note that modifying this register trashes any attempted
voltage scaling configuration and the change probably should
never have gotten merged in the first place.

Cc: Nishanth Menon <nm at ti.com>
Cc: Kevin Hilman <khilman at linaro.org>
Cc: Paul Walmsley <paul at pwsan.com>
Signed-off-by: Tero Kristo <t-kristo at ti.com>
[tony at atomide.com: updated comments to describe regression]
Signed-off-by: Tony Lindgren <tony at atomide.com>
---
 arch/arm/mach-omap2/pm34xx.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 1f3770a..87099bb 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -330,10 +330,6 @@ void omap_sram_idle(void)
 			omap3_sram_restore_context();
 			omap2_sms_restore_context();
 		}
-		if (core_next_state == PWRDM_POWER_OFF)
-			omap2_prm_clear_mod_reg_bits(OMAP3430_AUTO_OFF_MASK,
-					       OMAP3430_GR_MOD,
-					       OMAP3_PRM_VOLTCTRL_OFFSET);
 	}
 	omap3_intc_resume_idle();
 
-- 
1.8.1.1




More information about the linux-arm-kernel mailing list