[PATCH 2/2] usb: ehci-platform: Return immediately from suspend if ehci_suspend fails
Vivek Gautam
gautam.vivek at samsung.com
Tue Apr 8 21:00:42 PDT 2014
Patch 'b8efdaf USB: EHCI: add check for wakeup/suspend race'
adds a check for possible race between suspend and wakeup interrupt,
and thereby it returns -EBUSY as error code if there's a wakeup
interrupt.
So the platform host controller should not proceed further with
its suspend callback, rather should return immediately to avoid
powering down the essential things, like phy.
Signed-off-by: Vivek Gautam <gautam.vivek at samsung.com>
Cc: Alan Stern <stern at rowland.harvard.edu>
Cc: Hauke Mehrtens <hauke at hauke-m.de>
Cc: Hans de Goede <hdegoede at redhat.com>
---
Based on 'usb-next' branch of Greg's usb tree.
drivers/usb/host/ehci-platform.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index b3a0e11..60d3d1a 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -303,11 +303,13 @@ static int ehci_platform_suspend(struct device *dev)
int ret;
ret = ehci_suspend(hcd, do_wakeup);
+ if (ret)
+ return ret;
if (pdata->power_suspend)
pdata->power_suspend(pdev);
- return ret;
+ return 0;
}
static int ehci_platform_resume(struct device *dev)
--
1.7.10.4
More information about the linux-arm-kernel
mailing list