Intel I350 mini-PCIe card (igb) on Mirabox (mvebu / Armada 370)
thomas.petazzoni at free-electrons.com
Tue Apr 8 11:32:53 PDT 2014
Dear Jason Gunthorpe,
On Tue, 8 Apr 2014 12:22:30 -0600, Jason Gunthorpe wrote:
> > Ah correct. Though I'm still puzzled as to why the undefined behavior
> > works for me, and not for Willy, who I believe has the same NIC as me.
> If we knew the algorithm in the HW it would probably make sense :)
> > But I am not sure with this one. Since now you're anyway rounding down
> > sizes, how is it possible to get a non-power-of-two size in the
> > registers?
> I agree, it should not happen if everything is correct, but the
> apparently correct debugfs output obscured the root cause of the
> > That being said, this warning doesn't really solve the problem that the
> > PCI core may allocate BARs whose size cannot be represented through
> > MBus windows :-)
> Right, but Will pointed out it took 3 months to get to the root cause,
> so it might save that time in future :)
Yes, I completely agree, and I'm totally in favor of making things more
robust in mvebu-mbus.
Actually, should we simply return an error if something tries to set up
a window with an invalid size? But maybe it's a bit too strong for the
moment, until the power of two size problem gets resolved on the PCI
But the other day, I also had funky issues with another window, and it
turned out to be caused by a non-power-of-two window as well...
> I'll revise/resend the patch.
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
More information about the linux-arm-kernel