[PATCH 06/17] ARM: exynos: cpuidle: Fix S5P_WAKEUP_STAT call

Viresh Kumar viresh.kumar at linaro.org
Fri Apr 4 01:53:02 PDT 2014


On 4 April 2014 13:17, Daniel Lezcano <daniel.lezcano at linaro.org> wrote:
> This function should be called only when the powerdown sequence fails.
>
> Even if the current code does not hurt, by moving this line, we have the same
> code than the one in pm.c.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano at linaro.org>
> ---
>  arch/arm/mach-exynos/cpuidle.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
> index 9cd1ed9..a1e1882 100644
> --- a/arch/arm/mach-exynos/cpuidle.c
> +++ b/arch/arm/mach-exynos/cpuidle.c
> @@ -135,11 +135,10 @@ static int exynos_enter_core0_aftr(struct cpuidle_device *dev,
>         if (!(tmp & S5P_CENTRAL_LOWPWR_CFG)) {
>                 tmp |= S5P_CENTRAL_LOWPWR_CFG;
>                 __raw_writel(tmp, S5P_CENTRAL_SEQ_CONFIGURATION);
> +               /* Clear wakeup state register */
> +               __raw_writel(0x0, S5P_WAKEUP_STAT);
>         }
>
> -       /* Clear wakeup state register */
> -       __raw_writel(0x0, S5P_WAKEUP_STAT);
> -
>         return index;
>  }

Reviewed-by: Viresh Kumar <viresh.kumar at linaro.org>



More information about the linux-arm-kernel mailing list