[PATCH] pinctrl: capri: make Kconfig dependency more strict

Sherman Yin syin at broadcom.com
Wed Apr 2 16:19:58 PDT 2014


On 14-04-01 01:10 PM, Uwe Kleine-König wrote:
> This driver is only useful on BCM281xx, so let the driver depend on
> ARCH_BCM_MOBILE but allow compile coverage testing.
> The main benefit is that the driver isn't available to be selected for
> machines that don't have the matching hardware.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>   drivers/pinctrl/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index e49324032611..072749816cb4 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -106,7 +106,7 @@ config PINCTRL_BCM2835
>
>   config PINCTRL_CAPRI
>   	bool "Broadcom Capri pinctrl driver"
> -	depends on OF
> +	depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
>   	select PINMUX
>   	select PINCONF
>   	select GENERIC_PINCONF
>

Looks good. Just wondering how you've come across this driver (and 
PINCTRL_MSM8X74)?

Reviewed-by: Sherman Yin <syin at broadcom.com>

Thanks,
Sherman



More information about the linux-arm-kernel mailing list