[PATCH 3/4] clk: kirkwood: Add CLK_IGNORE_UNUSED to ethernet ge0 and ge1 clocks

Jason Cooper jason at lakedaemon.net
Mon Sep 30 20:40:09 EDT 2013


On Mon, Sep 30, 2013 at 06:03:29PM -0300, Ezequiel Garcia wrote:
> These clocks should never be gated, since the ethernet interfaces forget
> the assigned MAC address assigned if their clock source is turned off.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> ---
> Cc: Mike Turquette <mturquette at linaro.org>
> 
>  drivers/clk/mvebu/kirkwood.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

I'm inclined to leave this as a hack in board-dt.c...  At some point we
are going to move kirkwood over to mach-mvebu/, and there will be eyes
on the code.  There's less chance of 're-discovering' this for cleanup
if it's in the clock driver, looking all proper and such.  Even with the
clear comment.

thx,

Jason.



More information about the linux-arm-kernel mailing list